🎨 [Frontend] Enh: RM 03.06 #7794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
requested review from
GitHK,
Copilot,
matusdrobuliak66,
pcrespov and
sanderegg
matusdrobuliak66
approved these changes
Jun 3, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Enhance frontend functionality for RM 03.06 by updating links, conditionally hiding filters, improving menu icons, and fetching comment author data asynchronously.
- Introduce
showTemplatesandshowPublicProjectsutilities and apply them to resource views and filters to hide Templates/Public Projects in TIP/TIP-lite. - Refactor
CommentUIto asynchronously fetch user details for comment thumbnails. - Update the "More" menu icon in
NewPlusMenuto a double-chevron and adjust its styling.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/product/Utils.js | Added showTemplates and showPublicProjects methods to control visibility |
| services/static-webserver/client/source/class/osparc/info/CommentUI.js | Switched to Users.getInstance().getUser(...) promise for fetching user info |
| services/static-webserver/client/source/class/osparc/data/SubJob.js | Moved most property initialization into updateSubJob to avoid duplication |
| services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js | Applied visibility checks for publish and template pages with new util methods |
| services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserFilter.js | Conditionally render Templates and Public Projects filters; adjust hypertool icon size |
| services/static-webserver/client/source/class/osparc/dashboard/NewPlusMenu.js | Renamed __addOtherTabsAccess to __addMoreMenu, updated menu icon and margin styling |
services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js
Show resolved
Hide resolved
sanderegg
approved these changes
Jun 3, 2025
Member
Author
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at cef4362 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue/s
How to test
Dev-ops